Skip to content

Conversation

@swamirishi
Copy link
Contributor

@swamirishi swamirishi commented Nov 7, 2022

What changes were proposed in this pull request?

Changing hdds.scm.replication.thread.interval to run Replication Manager more frequently which defaults to 300s should fix intermittency of the tests under class.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7326

How was this patch tested?

UT changes

@swamirishi
Copy link
Contributor Author

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swamirishi for the fix, and testing it in repeated run.

Copy link
Member

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swamirishi for the fix and test. The change looks good, just some nitpicking here.

@kaijchen kaijchen merged commit 14a1668 into apache:master Nov 8, 2022
@kaijchen
Copy link
Member

kaijchen commented Nov 8, 2022

Thanks @swamirishi for updating the patch, and @adoroszlai for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants