HDDS-7487. Support fine grained certificate lifetime for efficient test.#3954
Merged
ChenSammi merged 3 commits intoapache:masterfrom Nov 17, 2022
Merged
HDDS-7487. Support fine grained certificate lifetime for efficient test.#3954ChenSammi merged 3 commits intoapache:masterfrom
ChenSammi merged 3 commits intoapache:masterfrom
Conversation
Galsza
approved these changes
Nov 14, 2022
Contributor
Galsza
left a comment
Galsza
left a comment
There was a problem hiding this comment.
Looking good to me.
Thanks for working on this.
Contributor
Author
|
Hi @fapifta , would you like to take another look? |
Contributor
|
I did, one question popped up in my mind while looking at the changes again, why we change the test from BlockTokenSecretManager to ContainerTokenSecretManager? |
Contributor
Author
Because it's container creation operation in the test, which requires a container token, not a block token. BlockTokenSecretManager is misused here. |
fapifta
approved these changes
Nov 17, 2022
Contributor
fapifta
left a comment
fapifta
left a comment
There was a problem hiding this comment.
ah ok, I should have noticed :)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-7487