Skip to content

Conversation

@sadanand48
Copy link
Contributor

@sadanand48 sadanand48 commented Dec 2, 2022

What changes were proposed in this pull request?

Add option to show key count in DBScanner.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7580

How was this patch tested?

bash-4.2$ ozone debug ldb --db=/data/metadata/om.db scan --column_family=keyTable -count
Tested on docker , added unit tests.

@kerneltime
Copy link
Contributor

@duongkame please take a look as well.

Copy link
Contributor

@duongkame duongkame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1.

Copy link
Contributor

@aryangupta1998 aryangupta1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, LGTM!

@aryangupta1998 aryangupta1998 merged commit 76fb016 into apache:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants