HDDS-7583. Support efficient Snapdiff only until configured Snapshot History#4036
Merged
prashantpogde merged 1 commit intoapache:HDDS-6517-Snapshotfrom Dec 13, 2022
Merged
Conversation
prashantpogde
approved these changes
Dec 13, 2022
Contributor
|
UT failure is related: https://github.com/apache/ozone/actions/runs/3604533693/jobs/6073987647 Is this new config actually being used anywhere yet? |
Contributor
Author
No |
Contributor
Okay. Could you fix the test breakage with an addendum? It is failing on the snapshot feature branch now: https://github.com/apache/ozone/actions/runs/3689651078/jobs/6245836865 It will start to break everyone else's CI once they rebased to the latest snapshot branch. |
Contributor
|
I am reverting this commit now that it is failing other commit's post-commit CI on the snapshot feature branch: Please raise a new PR when the proper changes are done for HDDS-7583. Thanks! |
smengcl
added a commit
that referenced
this pull request
Dec 16, 2022
smengcl
added a commit
that referenced
this pull request
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding config to only support Snapshot based on the max number of Snapshot history count
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7583
How was this patch tested?
Only Config changes. No unit test cases required