HDDS-7619. Update SCM term in datanode when command is received#4072
Merged
sodonnel merged 6 commits intoapache:masterfrom Dec 13, 2022
Merged
HDDS-7619. Update SCM term in datanode when command is received#4072sodonnel merged 6 commits intoapache:masterfrom
sodonnel merged 6 commits intoapache:masterfrom
Conversation
siddhantsangwan
approved these changes
Dec 13, 2022
Contributor
siddhantsangwan
left a comment
There was a problem hiding this comment.
@adoroszlai The changes look good to me!
Contributor
|
Do we have multiple threads adding and getting commands from the command queue? Even if we have multiple threads, I don't think there are any potential problems related to multithreaded inconsistency in the new code. I'm asking for better understanding. |
Contributor
Author
|
Thanks @siddhantsangwan, @sodonnel for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update datanode's record of "SCM leader term" as soon as command is added to the queue to help drop obsolete commands sooner.
https://issues.apache.org/jira/browse/HDDS-7619
How was this patch tested?
Added unit test.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3677335765