Skip to content

HDDS-7607. [Snapshot] SnapshotDiff command lists unmodified file as modified#4108

Merged
smengcl merged 4 commits intoapache:HDDS-6517-Snapshotfrom
sadanand48:HDDS-7682
Jan 3, 2023
Merged

HDDS-7607. [Snapshot] SnapshotDiff command lists unmodified file as modified#4108
smengcl merged 4 commits intoapache:HDDS-6517-Snapshotfrom
sadanand48:HDDS-7682

Conversation

@sadanand48
Copy link
Contributor

@sadanand48 sadanand48 commented Dec 19, 2022

What changes were proposed in this pull request?

Fix issue which shows key as modified

bash-4.2$ ozone sh volume create vol1
bash-4.2$ ozone sh bucket create vol1/buck1
bash-4.2$ ozone sh key put vol1/buck1/key1
bash-4.2$ ozone sh snapshot create vol1/buck1 snap1
bash-4.2$ ozone sh snapshot create vol1/buck1 snap2
bash-4.2$ ozone sh snapshot snapshotDiff vol1/buck1 snap1 snap2
Difference between snapshot snap1 and snapshot snap2:
M key1

Also fixed snapdiff for FSO buckets

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7607

How was this patch tested?

Added Basic Snapdiff unit tests

@sadanand48 sadanand48 marked this pull request as ready for review December 20, 2022 05:06
@sadanand48 sadanand48 changed the title HDDS-7682. [Snapshot] Snapdiff showing incorrect result. HDDS-7607. [Snapshot] SnapshotDiff command lists unmodified file as modified Dec 20, 2022
@sadanand48 sadanand48 added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Dec 20, 2022
Change-Id: Ic21c2b80f0b553fc5446b5745b95d431a6e9f9b1
@smengcl smengcl merged commit 125eccf into apache:HDDS-6517-Snapshot Jan 3, 2023
@smengcl
Copy link
Contributor

smengcl commented Jan 3, 2023

Thanks @sadanand48 for the fix and test addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants