Skip to content

HDDS-7806. Add unit tests for push replication#4216

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-7806
Jan 27, 2023
Merged

HDDS-7806. Add unit tests for push replication#4216
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-7806

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Add unit test for SendContainerOutputStream and PushReplicator.

https://issues.apache.org/jira/browse/HDDS-7806

How was this patch tested?

[INFO] Running org.apache.hadoop.ozone.container.replication.TestSendContainerOutputStream
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.324 s - in org.apache.hadoop.ozone.container.replication.TestSendContainerOutputStream
[INFO] Running org.apache.hadoop.ozone.container.replication.TestPushReplicator
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.346 s - in org.apache.hadoop.ozone.container.replication.TestPushReplicator

@adoroszlai adoroszlai self-assigned this Jan 27, 2023
Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit 75a28b2 into apache:master Jan 27, 2023
@adoroszlai adoroszlai deleted the HDDS-7806 branch January 27, 2023 20:14
@adoroszlai
Copy link
Contributor Author

Thanks @sodonnel for the review.

@kaijchen
Copy link
Member

Hi @adoroszlai, looks like TestPushReplicator is flaky.

@adoroszlai
Copy link
Contributor Author

Thanks @kaijchen, I also encountered this in followup changes. I'll disable it until I can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants