HDDS-7821. Let push replication use compression from configuration #4229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodonnel
approved these changes
Feb 1, 2023
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM, and I believe you are planning to add some integration tests or acceptance test in another PR will will help give more confidence on the new flow and compression settings.
Contributor
Author
|
Thanks @sodonnel for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Initial implementation of push replication had hard-coded "no compression", ignoring the configuration, which is currently only used by the pull direction. The goal of this change is to use the compression defined in the config for push, too.
PushReplicatorandDownloadAndImportReplicatortake the compression from config. Other components (ContainerDownloader,ContainerImporter,ContainerReplicationSource) apply the compression passed to them by their callers. This is required because the actual compression is decided by the datanode that initiates the replication (source or target, depending on direction). The other party applies the compression specified in the request.Refactored
CopyContainerCompressionto use enum features instead of a string-based mapping, and moved all compressor-related logic into it.https://issues.apache.org/jira/browse/HDDS-7821
How was this patch tested?
Added unit tests.
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4056964585