HDDS-7879. Intermittent BindException in HA integration tests#4241
Merged
adoroszlai merged 2 commits intoapache:masterfrom Feb 2, 2023
Merged
HDDS-7879. Intermittent BindException in HA integration tests#4241adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
szetszwo
approved these changes
Feb 2, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@adoroszlai , Thanks a lot for fixing the bug!
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid starting Netty datastream service for OM/SCM HA Ratis servers, to reduce the probability of port conflicts (due to random ports).
https://issues.apache.org/jira/browse/HDDS-7879
How was this patch tested?
Successfully repeated (30x) HA integration tests that have been observed to fail due to port conflict by Netty:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4075097777
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4075532254
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4076857712
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4075093534