Skip to content

HDDS-7966. Replace Hadoop annotations with Ozone-specific ones#4282

Merged
adoroszlai merged 1 commit intoapache:HDDS-5447-httpfsfrom
adoroszlai:HDDS-7966
Feb 18, 2023
Merged

HDDS-7966. Replace Hadoop annotations with Ozone-specific ones#4282
adoroszlai merged 1 commit intoapache:HDDS-5447-httpfsfrom
adoroszlai:HDDS-7966

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Replace new usage of Hadoop's InterfaceAudience and InterfaceStability annotations with Ozone-specific ones (introduced in HDDS-3028).

https://issues.apache.org/jira/browse/HDDS-7966

How was this patch tested?

Build and checkstyle:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4194009972

@adoroszlai adoroszlai self-assigned this Feb 16, 2023
@adoroszlai
Copy link
Contributor Author

@fapifta @dombizita

Copy link
Contributor

@swamirishi swamirishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerneltime
Copy link
Contributor

Some of the core EC code, a copy-paste of Hadoop, will continue to use the Hadoop annotations. It might be a good idea to check in a selective checkout of the Hadoop EC code with the git history.

@adoroszlai
Copy link
Contributor Author

Some of the core EC code, a copy-paste of Hadoop, will continue to use the Hadoop annotations

Those are already fixed in master (HDDS-7967).

@kerneltime
Copy link
Contributor

Some of the core EC code, a copy-paste of Hadoop, will continue to use the Hadoop annotations

Those are already fixed in master (HDDS-7967).

Ah! I get a gh pr checkout 4282 and this branch did not have that change.

@adoroszlai adoroszlai merged commit 7563f34 into apache:HDDS-5447-httpfs Feb 18, 2023
@adoroszlai
Copy link
Contributor Author

Thanks @kerneltime, @swamirishi for the review.

@adoroszlai adoroszlai deleted the HDDS-7966 branch February 18, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants