HDDS-7989. UnhealthyReplicationProcessor retries failure without delay#4285
Merged
sodonnel merged 2 commits intoapache:masterfrom Feb 21, 2023
Merged
HDDS-7989. UnhealthyReplicationProcessor retries failure without delay#4285sodonnel merged 2 commits intoapache:masterfrom
sodonnel merged 2 commits intoapache:masterfrom
Conversation
sodonnel
approved these changes
Feb 21, 2023
Contributor
Author
|
Thanks @sodonnel for reviewing and committing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
UnhealthyReplicationProcessor#processAllrequeues any failed task. Such tasks are attempted in the sameprocessAllcall, before exiting the loop. This can flood SCM logs until the cause of the error is resolved.This causes Github's environment to run out of disk space in just a few minutes after testing EC reconstruction read (test being added in HDDS-7982).
This PR proposes to collect failed container health results and requeue them only after exiting the loop.
https://issues.apache.org/jira/browse/HDDS-7989
How was this patch tested?
Added unit test.
Also verified together with HDDS-7982 (which uncovered the problem without this fix):
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4207471575/jobs/7302558782
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4207414175