HDDS-7588. Intermittent failure in TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS#4290
Merged
adoroszlai merged 1 commit intoapache:masterfrom Feb 20, 2023
Merged
Conversation
…atKeyStructureWithOBS
adoroszlai
approved these changes
Feb 20, 2023
Contributor
|
Thanks @kaijchen for the fix. |
Member
Author
|
Thanks @adoroszlai for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It turns out that the previous fix #4040 was not correct, in term of matching the original intention of this test.
I have reverted c119557 on master.
This PR is a 2nd attempt to fix the flaky test
TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS,without changing the original intention (so it matches with the javadoc).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7588
How was this patch tested?
Full CI: https://github.com/kaijchen/ozone/actions/runs/4221363513
Repeat 1000x: https://github.com/kaijchen/ozone/actions/runs/4221392332