Skip to content

HDDS-7588. Intermittent failure in TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS#4290

Merged
adoroszlai merged 1 commit intoapache:masterfrom
kaijchen:HDDS-7588
Feb 20, 2023
Merged

HDDS-7588. Intermittent failure in TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS#4290
adoroszlai merged 1 commit intoapache:masterfrom
kaijchen:HDDS-7588

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Feb 20, 2023

What changes were proposed in this pull request?

Quoted from javadoc of testFlatKeyStructureWithOBS():

Test verifies that OBS bucket keys should create flat key-value
structure and intermediate directories shouldn't be created even
if the OZONE_OM_ENABLE_FILESYSTEM_PATHS flag is TRUE.

It turns out that the previous fix #4040 was not correct, in term of matching the original intention of this test.
I have reverted c119557 on master.

This PR is a 2nd attempt to fix the flaky test TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS,
without changing the original intention (so it matches with the javadoc).

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7588

How was this patch tested?

Full CI: https://github.com/kaijchen/ozone/actions/runs/4221363513
Repeat 1000x: https://github.com/kaijchen/ozone/actions/runs/4221392332

@kaijchen kaijchen marked this pull request as ready for review February 20, 2023 10:49
@adoroszlai adoroszlai merged commit 501152d into apache:master Feb 20, 2023
@adoroszlai
Copy link
Contributor

Thanks @kaijchen for the fix.

@kaijchen kaijchen deleted the HDDS-7588 branch February 21, 2023 02:14
@kaijchen
Copy link
Member Author

Thanks @adoroszlai for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants