HDDS-8020. File checksum helper leaking client#4307
Merged
adoroszlai merged 1 commit intoapache:masterfrom Feb 24, 2023
Merged
Conversation
Contributor
Author
|
Thanks @ayushtkn, @duongkame, @sodonnel for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Let file checksum helper release client in case of success to prevent memleak.
(It seems logic for releasing client was copied from
BlockInputStream, which has been fixed in HDDS-7931 since then.)https://issues.apache.org/jira/browse/HDDS-8020
How was this patch tested?
Verified no warning about
ManagedChannelImpl was not shutdown properlyappears in test log.CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4257319915