HDDS-8026. Replace import from shaded Guava#4314
Merged
adoroszlai merged 2 commits intoapache:masterfrom Feb 24, 2023
Merged
Conversation
ayushtkn
reviewed
Feb 24, 2023
Member
ayushtkn
left a comment
There was a problem hiding this comment.
Makes sense. But this would be a continuous effort I feel. People will keep on adding it and someone has to regularly volunteer to get rid of them.
Is there some scope to enforce checks to prevent this in future. Hadoop I feel does something like this here:
https://github.com/apache/hadoop/blob/4067facae6eac03ec31612134dc93b113d09ee80/pom.xml#L173-L188
Contributor
Author
|
Thanks @ayushtkn for the suggestion, added the restriction. Without the import replacements: |
kerneltime
approved these changes
Feb 24, 2023
Contributor
Author
|
Thanks @ayushtkn, @kerneltime for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Directly use Guava classes instead of the shaded ones from
ratis-thirdparty.https://issues.apache.org/jira/browse/HDDS-8026
How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4262730397