HDDS-8034. Check container replication health before scheduling move in MoveManager#4321
Merged
sodonnel merged 2 commits intoapache:masterfrom Feb 27, 2023
Merged
Conversation
sodonnel
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MoveManager#movealready checks if a container has any in-flight (pending) Adds or Deletes before scheduling a move. However, there is some time between the replication thread checking the health of a container and queuing it and theUnhealthyReplicationProcessorthread picking containers from the queue and scheduling Adds and Deletes. To be safe, we should also check the container's health inMoveManagerbefore scheduling move.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8034
How was this patch tested?
Added UT.