HDDS-8073. Replace Usages of LegacyReplicationManager.MoveResult with MoveManager.MoveResult#4339
Merged
sodonnel merged 2 commits intoapache:masterfrom Mar 6, 2023
Merged
Conversation
… MoveManager.MoveResult
sodonnel
approved these changes
Mar 3, 2023
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM. One small thing - can we remove LegacyReplicationManager.MoveResult to ensure nothing is referencing it / using it now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces usages of LegacyReplicationManager.MoveResult with corresponding MoveManager.MoveResult results. This will allow Container Balancer to use MoveManager in the future while maintaining compatibility with Legacy Replication Manager.
Added logs wherever we're failing with
FAIL_UNEXPECTED_ERROR.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8073
How was this patch tested?
No new tests required.