Skip to content

HDDS-8078. Github CI: Allow PR title starting with Revert#4348

Merged
kaijchen merged 4 commits intoapache:masterfrom
smengcl:HDDS-8078
Mar 6, 2023
Merged

HDDS-8078. Github CI: Allow PR title starting with Revert#4348
kaijchen merged 4 commits intoapache:masterfrom
smengcl:HDDS-8078

Conversation

@smengcl
Copy link
Copy Markdown
Contributor

@smengcl smengcl commented Mar 4, 2023

What changes were proposed in this pull request?

Allow PR title starting with Revert " to pass the PR CI title check.

Support the default title generated by Github's built-in revert PR feature.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8078

How was this patch tested?

Copy link
Copy Markdown
Member

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @smengcl for the improvement.

PS: Can we improve the Fail: must start with HDDS message?

Change-Id: Ic954363037a331e97f366ea14910c56fa3d2fdda
@smengcl
Copy link
Copy Markdown
Contributor Author

smengcl commented Mar 4, 2023

Thanks @kaijchen for the review.

PS: Can we improve the Fail: must start with HDDS message?

Doable but not without complicating the checker script. Currently it's just a simple line to strip the string, since the idea is just to ignore the leading Revert ".

I've added a message to improve clarity, hopefully:

❯ ./dev-support/ci/pr_title_check.sh 'Revert "HDDS-12345. Hello World"'
Leading 'Revert "' in the PR title has been stripped solely for this title checking purpose. Performing actual title check on:
HDDS-12345. Hello World"
OK
❯ ./dev-support/ci/pr_title_check.sh 'HDDS-12345. Hello World' 
OK

smengcl added 2 commits March 3, 2023 20:31
Change-Id: Ib84b0947a7ff50cf89eaf6f3bb9417e093781fc8
Change-Id: I5bfa748fc6b34357043a7a13926f98d8a10d82d1
@kaijchen kaijchen merged commit 30a6d3b into apache:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants