HDDS-8078. Github CI: Allow PR title starting with Revert#4348
Merged
kaijchen merged 4 commits intoapache:masterfrom Mar 6, 2023
Merged
HDDS-8078. Github CI: Allow PR title starting with Revert#4348kaijchen merged 4 commits intoapache:masterfrom
kaijchen merged 4 commits intoapache:masterfrom
Conversation
Change-Id: Ic954363037a331e97f366ea14910c56fa3d2fdda
Contributor
Author
|
Thanks @kaijchen for the review.
Doable but not without complicating the checker script. Currently it's just a simple line to strip the string, since the idea is just to ignore the leading I've added a message to improve clarity, hopefully: |
Change-Id: I5bfa748fc6b34357043a7a13926f98d8a10d82d1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow PR title starting with
Revert "to pass the PR CI title check.Support the default title generated by Github's built-in revert PR feature.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8078
How was this patch tested?
Revert "in PR title has passed: