HDDS-7958. Ozone client not closed in integration tests#4373
Merged
adoroszlai merged 39 commits intoapache:masterfrom Mar 16, 2023
Merged
HDDS-7958. Ozone client not closed in integration tests#4373adoroszlai merged 39 commits intoapache:masterfrom
adoroszlai merged 39 commits intoapache:masterfrom
Conversation
duongkame
reviewed
Mar 15, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java
Outdated
Show resolved
Hide resolved
...ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFSBucketLayout.java
Show resolved
Hide resolved
...ne/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemMetrics.java
Show resolved
Hide resolved
duongkame
approved these changes
Mar 15, 2023
Contributor
duongkame
left a comment
duongkame
left a comment
There was a problem hiding this comment.
Thanks for doing the hard work to clean the integration tests up, @adoroszlai.
This PR is very important in the sense that, after this change, any leak warning in the integ test log is considered a real prod problem immediately without double checking if it's from a test.
The code looks good. I just put a suggestion to simplify the code changes a bit more.
...n-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/TestMiniChaosOzoneCluster.java
Outdated
Show resolved
Hide resolved
...ne/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemMetrics.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks @duongkame for the helpful reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update lots of integration tests to properly close
OzoneClient,OzoneInputStream,ScmClient,XceiverClient*after use.https://issues.apache.org/jira/browse/HDDS-7958
How was this patch tested?
Ran integration tests, checked for
ManagedChannelImpl ... was not shutdownreports.https://github.com/adoroszlai/hadoop-ozone/actions/runs/4379443303