HDDS-8111. ReplicationManager: Add RatisMisReplicationHandler into rm.processUnderReplicatedContainer#4414
Merged
adoroszlai merged 1 commit intoapache:masterfrom Mar 17, 2023
Merged
Conversation
….processUnderReplicatedContainer
adoroszlai
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We missed adding the RatisMisReplicationHandler into the ReplicationManager.processUnderReplicatedContainer() method. This means that RatisMisReplication is never handled.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8111
How was this patch tested?
There are currently no tests for this. Testing it in the existing TestReplicationManager class is too difficult.
It is our intention to build full integration tests using mini-cluster for ReplicationManager which will test this and the full RM full more completely.