HDDS-8240. Disable JaCoCo for PRs and in forks#4449
Merged
adoroszlai merged 1 commit intoapache:masterfrom Mar 25, 2023
Merged
Conversation
smengcl
approved these changes
Mar 25, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
lgtm. Thanks @adoroszlai for the improvement
adoroszlai
added
enhancement
Contributor
Author
|
Thanks @smengcl for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Coverage check is executed only for commits in
apache/ozone, i.e. neither for pull requests inapache/ozone, nor for any event in forks (HDDS-4801). However, coverage data is still collected during test runs, which (1) uses space unnecessarily in result bundles, and (2) takes a tiny bit of time to execute. This PR disables JaCoCo for the cases when its output is ignored.https://issues.apache.org/jira/browse/HDDS-8240
How was this patch tested?
JaCoCo is executed in CI simulating commit on
apache/ozonerepo:https://github.com/adoroszlai/hadoop-ozone/actions/runs/4489193839/jobs/7897102199#step:5:3513
but skipped in fork:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4489001536/jobs/7897164734#step:5:3560
jacoco*.execfiles are not present in the artifacts produced by the latter.