Skip to content

HDDS-7781. Change Get Key Info to return HSync info #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 4 commits into from
Mar 28, 2023
Merged

HDDS-7781. Change Get Key Info to return HSync info #4460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09115ec
WIP
jojochuang Mar 21, 2023
a4632ab
Update
jojochuang Mar 21, 2023
4eb8a98
Fix test bugs
jojochuang Mar 22, 2023
7afdec9
Update: no more extra field for isHsync.
jojochuang Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,10 @@ public boolean isFile() {
return isFile;
}

public boolean isHsync() {
return metadata.containsKey(OzoneConsts.HSYNC_CLIENT_ID);
}

/**
* updates the length of the each block in the list given.
* This will be called when the key is being committed to OzoneManager.
Expand Down
6 changes: 6 additions & 0 deletions hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestOmKeyInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.hadoop.hdds.scm.pipeline.PipelineID;
import org.apache.hadoop.ozone.ClientVersion;
import org.apache.hadoop.ozone.OzoneAcl;
import org.apache.hadoop.ozone.OzoneConsts;
import org.apache.hadoop.ozone.om.helpers.OmKeyInfo.Builder;
import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
Expand Down Expand Up @@ -59,6 +60,10 @@ public void protobufConversion() throws IOException {
key.getProtobuf(ClientVersion.CURRENT_VERSION));

Assert.assertEquals(key, keyAfterSerialization);

Assert.assertFalse(key.isHsync());
key.getMetadata().put(OzoneConsts.HSYNC_CLIENT_ID, "clientid");
Assert.assertTrue(key.isHsync());
}

@Test
Expand All @@ -82,6 +87,7 @@ public void getProtobufMessageEC() throws IOException {

// EC Config
key = createOmKeyInfo(new ECReplicationConfig(3, 2));
Assert.assertFalse(key.isHsync());
omKeyProto = key.getProtobuf(ClientVersion.CURRENT_VERSION);

Assert.assertEquals(3, omKeyProto.getEcReplicationConfig().getData());
Expand Down