Skip to content

HDDS-8265. [Snapshot] Close ManagedColumnFamilyOptions properly in OmSnapshotManager#4465

Merged
smengcl merged 1 commit into
apache:masterfrom
hemantk-12:HDDS-8265
Mar 23, 2023
Merged

HDDS-8265. [Snapshot] Close ManagedColumnFamilyOptions properly in OmSnapshotManager#4465
smengcl merged 1 commit into
apache:masterfrom
hemantk-12:HDDS-8265

Conversation

@hemantk-12
Copy link
Copy Markdown
Contributor

@hemantk-12 hemantk-12 commented Mar 23, 2023 •
edited
Loading

What changes were proposed in this pull request?

Close leaking ManagedColumnFamilyOptions object in OmSnapshotManager.

Created ManagedColumnFamilyOptions@451f08ea
	at org.apache.hadoop.hdds.utils.db.managed.ManagedColumnFamilyOptions.<init>(ManagedColumnFamilyOptions.java:47)
	at org.apache.hadoop.ozone.om.OmSnapshotManager.<init>(OmSnapshotManager.java:139)
	at org.apache.hadoop.ozone.om.OzoneManager.instantiateServices(OzoneManager.java:774)
	at org.apache.hadoop.ozone.om.OzoneManager.<init>(OzoneManager.java:628)
	at org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:713)

...

Other RocksDB's related objected were close properly in: #4461

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8265

How was this patch tested?

No more leak warnings ManagedColumnFamilyOptions is not closed properly when running Snapshot integration test.

@aswinshakil aswinshakil added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Mar 23, 2023
@duongkame duongkame self-requested a review March 23, 2023 22:12
duongkame
duongkame approved these changes Mar 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@duongkame duongkame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @hemantk-12

@DaveTeng0
Copy link
Copy Markdown
Contributor

DaveTeng0 commented Mar 23, 2023

lgtm!

@smengcl smengcl merged commit 68eb26d into apache:master Mar 23, 2023
@smengcl
Copy link
Copy Markdown
Contributor

smengcl commented Mar 23, 2023

Thanks @hemantk-12 for the fix. Thanks @duongkame and @DaveTeng0 for the reviews.

@hemantk-12 hemantk-12 deleted the HDDS-8265 branch October 28, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duongkame duongkame duongkame approved these changes

@smengcl smengcl smengcl approved these changes

Assignees

No one assigned

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hemantk-12 @DaveTeng0 @smengcl @duongkame @aswinshakil