HDDS-7907. [hsync] KeyOutputStream is not thread safe. #4601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I285cb100852d2a8ce7c563fc580dcc7d921d3a5b
Contributor
Author
|
@szetszwo The fix is not ready yet. I'd like to ask you for review when I update the PR with the fix. Thanks! |
Change-Id: Ic39cfc5e98e5736c3b9ae7b8c4ea0a7a88ad8e91
jojochuang
changed the title
szetszwo
approved these changes
Apr 24, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks for the review! I'll actually update the PR and jira description. It turns out that just making BlockOutputStream synchronized is not enough. I ended up having to synchronize KeyOutputStream. Re-trigger the test just to double check. |
jojochuang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Synchronize every public interface of KeyOutputStream.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7907
How was this patch tested?
Unit test. Will also verify using HBase workloads too.