Skip to content

HDDS-8468. Fix Native JDK 11, 17 compile#4603

Merged
adoroszlai merged 2 commits intoapache:masterfrom
swamirishi:HDDS-8468
Apr 25, 2023
Merged

HDDS-8468. Fix Native JDK 11, 17 compile#4603
adoroszlai merged 2 commits intoapache:masterfrom
swamirishi:HDDS-8468

Conversation

@swamirishi
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Currently native header file compilation fails for jdk11 & jdk 17.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8468

How was this patch tested?

Local testing

@swamirishi
Copy link
Copy Markdown
Contributor Author

@smengcl @adoroszlai Can you take a look at this?

@adoroszlai
Copy link
Copy Markdown
Contributor

@swamirishi thanks for working on this.

Since native build is not included in regular CI, please:

  1. create a test branch based on HDDS-8468
  2. make a temporary commit:
    • hard-code -Drocks_tools_native in build.sh
    • increase timeout of build and compile checks in ci.yml if necessary
  3. push to your fork
  4. link to the CI run of the test branch in the PR description

This will provide test coverage for the change.

@adoroszlai adoroszlai added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Apr 21, 2023
@swamirishi
Copy link
Copy Markdown
Contributor Author

swamirishi commented Apr 21, 2023

Thank you @adoroszlai for reviewing this:
Check https://github.com/swamirishi/ozone/actions/runs/4763117983/jobs/8466821254 for the ci run on test branch swamirishi@05ed061

@adoroszlai
Copy link
Copy Markdown
Contributor

Thanks @swamirishi for the test run, looks good.

@swamirishi
Copy link
Copy Markdown
Contributor Author

@adoroszlai Can this be merged?

@adoroszlai adoroszlai merged commit 70357d9 into apache:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants