HDDS-8468. Fix Native JDK 11, 17 compile#4603
Merged
adoroszlai merged 2 commits intoapache:masterfrom Apr 25, 2023
Merged
Conversation
Contributor
Author
|
@smengcl @adoroszlai Can you take a look at this? |
Contributor
|
@swamirishi thanks for working on this. Since native build is not included in regular CI, please:
This will provide test coverage for the change. |
Contributor
Author
|
Thank you @adoroszlai for reviewing this: |
Contributor
|
Thanks @swamirishi for the test run, looks good. |
Contributor
Author
|
@adoroszlai Can this be merged? |
smengcl
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently native header file compilation fails for jdk11 & jdk 17.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8468
How was this patch tested?
Local testing