HDDS-8482. Let Ozone shell support multiple OM services#4613
Merged
adoroszlai merged 2 commits intoapache:masterfrom Apr 26, 2023
Merged
HDDS-8482. Let Ozone shell support multiple OM services#4613adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
cc @DaveTeng0 @tanvipenumudy can you'll please take a look? |
Xushaohong
approved these changes
Apr 25, 2023
Contributor
Xushaohong
left a comment
There was a problem hiding this comment.
This is exactly the case under the condition "When host is an HA service ID" as the code
if (OmUtils.isOmHAServiceId(conf, ozoneURI.getHost())) , it is fine to choose the service id through URI host.
LTGM. Thanks @whbing for the work.
Contributor
Author
|
@Xushaohong Thanks for review. Added test. |
Xushaohong
approved these changes
Apr 25, 2023
Contributor
Author
|
All tests passed in https://github.com/whbing/ozone/actions/runs/4794048829 |
adoroszlai
approved these changes
Apr 26, 2023
Contributor
|
Thanks @whbing for the patch, @Xushaohong for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ozone cli support multiple ozone.om.service.ids
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8482
How was this patch tested?
manual tests passed.
without pr:
$ ozone sh vol ls o3://ozone1 Following ServiceID's [ozone1, ozone2] are defined in the configuration. Use the method getRpcClient which takes serviceID and configuration as paramwith pr: