HDDS-8473. ReplicationManager: Clear ContainerReplicaPendingOps when RM goes to running state#4644
Merged
siddhantsangwan merged 1 commit intoapache:masterfrom May 5, 2023
Merged
Conversation
…RM goes to running state
adoroszlai
reviewed
May 3, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sodonnel for the patch, LGTM.
Contributor
|
Thanks @sodonnel for the PR and @adoroszlai for the review. Merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ContainerReplicaPendingOps contains a record of all the pending replications which are waiting to complete across the cluster. When SCM steps down as a leader, and a new one takes over, the pending commands on the datanodes are dropped as they check the leader term before they are processed.
This means the contents of ContainerReplicaPendingOps is not needed if the SCM fails back to the original node. Therefore, if the SCM becomes active again, we should clear the pending ops when RM is transitioning to the RUNNING state.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8473
How was this patch tested?
New unit tests added.