HDDS-8542. In RDBTable, add a put method using RocksDB ByteBuffer APIs.#4666
Merged
szetszwo merged 4 commits intoapache:masterfrom May 7, 2023
Merged
HDDS-8542. In RDBTable, add a put method using RocksDB ByteBuffer APIs.#4666szetszwo merged 4 commits intoapache:masterfrom
szetszwo merged 4 commits intoapache:masterfrom
Conversation
adoroszlai
approved these changes
May 6, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch, looks very solid.
Comment on lines
+91
to
+103
| runTest(codec, original, original.length()); | ||
| } | ||
| gc(); | ||
| } | ||
|
|
||
| static <T> void runTest(Codec<T> codec, T original, | ||
| Integer serializedSize) throws Exception { | ||
| Assertions.assertTrue(codec.supportCodecBuffer()); | ||
|
|
||
| // serialize to byte[] | ||
| final byte[] array = codec.toPersistedFormat(original); | ||
| if (serializedSize != null) { | ||
| Assertions.assertEquals(serializedSize, array.length); |
Contributor
There was a problem hiding this comment.
This would fail if String has multibyte chars. Should pass String.getBytes(UTF_8).length instead of String.length(). This is not a problem with the current state of the code, since runTest is only called with Latin1 strings, but could be improved in the future.
Contributor
Author
There was a problem hiding this comment.
That's a good point! Thanks.
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
HDDS-8542
How was this patch tested?
Add new tests to test the codec implementations.