HDDS-7889. Intermittent failure in TestOzoneSnapshotRestore

[mladjan-gadzic]

What changes were proposed in this pull request?

The issue was that TestOzoneSnapshotRestore::keyCopy method was not finished copying keys when assertion for return value of TestOzoneSnapshotRestore::keyCount method was executed. It is proposed to use GenericTestUtils::waitFor to wait for TestOzoneSnapshotRestore::keyCount to return expected number of keys. For more info check comment section under linked Jira ticket.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7889

How was this patch tested?

• unit tests

[adoroszlai]

Thanks @mladjan-gadzic for working on this.

Please run the test repeatedly in CI (see aaa6e8b for an example) and post the results.

[mladjan-gadzic]

@adoroszlai thanks for the review!

Please run the test repeatedly in CI (see aaa6e8b for an example) and post the results.

I've been running those kind of tests for a quite some time. Please check https://github.com/mladjan-gadzic/ozone/actions/workflows/HDDS-7889.yml. There has not been a single failure since the last commit. Is that what you are referring to?

[adoroszlai]

I've been running those kind of tests for a quite some time. Please check https://github.com/mladjan-gadzic/ozone/actions/workflows/HDDS-7889.yml. There has not been a single failure since the last commit. Is that what you are referring to?

Yes, great work, thanks for the link.

[adoroszlai]

Thanks @mladjan-gadzic for updating the patch.

[mladjan-gadzic]

Thanks @adoroszlai for the review!