HDDS-8680. Optimize getting open pipelines from pipelineManager#4765
Merged
adoroszlai merged 1 commit intoapache:masterfrom May 24, 2023
Merged
HDDS-8680. Optimize getting open pipelines from pipelineManager#4765adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
Xushaohong
approved these changes
May 24, 2023
Contributor
Xushaohong
left a comment
Xushaohong
left a comment
There was a problem hiding this comment.
LGTM. Thanks @sodonnel for the refinement.
Contributor
|
+1 Thanks @sodonnel looking good to me. |
adoroszlai
approved these changes
May 24, 2023
Contributor
|
Thanks @sodonnel for the patch, @Galsza, @Xushaohong for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the WriteableECContainerProvider, we need to get the list of open pipelines on each block allocation request.
Open pipelines for a replication config can be retrieved efficiently from the PipelineStateMap.query2OpenPipelines variable.
However the list then needs to be filtered to remove excluded datanodes or pipelines. In the common case, these exclusions will be empty, so we can optimize this by skipping the iterator if there is nothing to filter out.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8680
How was this patch tested?
Existing tests should cover this.