HDDS-8746. Add metrics to ReplicationSupervisor for task count and max streams#4818
Merged
sodonnel merged 1 commit intoapache:masterfrom Jun 2, 2023
Merged
HDDS-8746. Add metrics to ReplicationSupervisor for task count and max streams#4818sodonnel merged 1 commit intoapache:masterfrom
sodonnel merged 1 commit intoapache:masterfrom
Conversation
adoroszlai
reviewed
Jun 1, 2023
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sodonnel for the patch, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To give added visibility into the Replication Queue on a datanode, this Jira adds some extra metrics to give visibility into the count of "normal priority" Replication and Reconstruction tasks, along with the current maxStreams setting, which is automatically adjusted when the node moves into decommission.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8746
How was this patch tested?
This was tested manually in Docker compose by sampling the JMX output. Sample output: