HDDS-8761. Support CodecBuffer for X509CertificateCodec.#4831
Merged
szetszwo merged 2 commits intoapache:masterfrom Jun 6, 2023
Merged
HDDS-8761. Support CodecBuffer for X509CertificateCodec.#4831szetszwo merged 2 commits intoapache:masterfrom
szetszwo merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Jun 6, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
...-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/X509CertificateCodec.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support CodecBuffer for X509CertificateCodec so it can use the RocksDB ByteBuffer API.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8761
How was this patch tested?
New tests