HDDS-8950. NPE in SCMCommonPlacementPolicy#validateContainerPlacement#4999
Merged
adoroszlai merged 1 commit intoapache:masterfrom Jun 28, 2023
Merged
HDDS-8950. NPE in SCMCommonPlacementPolicy#validateContainerPlacement#4999adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
sodonnel
approved these changes
Jun 28, 2023
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM. Nice work figuring out to root cause.
Contributor
Author
|
Thanks @sodonnel for the review. |
vtutrinov
pushed a commit
to Cyrill/ozone
that referenced
this pull request
Jul 3, 2023
vtutrinov
pushed a commit
to Cyrill/ozone
that referenced
this pull request
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix NPE in
validateContainerPlacementwhich can happen when trying to get placement group for dead node.Strictly speaking the fix is only this part:
https://issues.apache.org/jira/browse/HDDS-8950
How was this patch tested?
Added unit test.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5400935177