HDDS-8310. Recon goes down with RepeatedOmKeyInfo cannot be cast to OmKeyInfo#5043
Merged
jojochuang merged 9 commits intoapache:masterfrom Jul 13, 2023
Merged
HDDS-8310. Recon goes down with RepeatedOmKeyInfo cannot be cast to OmKeyInfo#5043jojochuang merged 9 commits intoapache:masterfrom
jojochuang merged 9 commits intoapache:masterfrom
Conversation
…rg.apache.hadoop.ozone.om.helpers.OmKeyInfo.
adoroszlai
changed the title
Contributor
Author
|
@jojochuang @ChenSammi @smengcl @devmadhuu Could you please take a look! |
smengcl
reviewed
Jul 11, 2023
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java
Outdated
Show resolved
Hide resolved
devmadhuu
reviewed
Jul 12, 2023
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Pls check and handle comments.
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java
Outdated
Show resolved
Hide resolved
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java
Outdated
Show resolved
Hide resolved
...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java
Outdated
Show resolved
Hide resolved
devmadhuu
reviewed
Jul 12, 2023
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Validator looks good. As discussed, With validator , we may not need changes in downstream ReconOmTask classes. You can revert and check logic earlier put.
Add positive and negative test cases for EventValidator.
…rg.apache.hadoop.ozone.om.helpers.OmKeyInfo.
jojochuang
reviewed
Jul 12, 2023
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
Contributor
|
@ArafatKhan2198 - Pls also update PR description which reflects the current change as no need to do any changes in downstream classes. |
jojochuang
reviewed
Jul 13, 2023
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Jul 13, 2023
...zone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestOmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Jul 13, 2023
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Looks almost ready. Just a few more nitpicks
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
jojochuang
approved these changes
Jul 13, 2023
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
LGTM pending precommit test @devmadhuu @smengcl anything you'd like to add?
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java
Outdated
Show resolved
Hide resolved
ashishkumar50
approved these changes
Jul 13, 2023
sumitagrawl
reviewed
Jul 13, 2023
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@ArafatKhan2198 Thanks for working over this,
We need analyze further with Recon DB available to check why oldValue type is wrong,
- check recon DB
- check from memory if really old value type is wrong for fileTable
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OMDBUpdatesHandler.java
Show resolved
Hide resolved
devmadhuu
approved these changes
Jul 13, 2023
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
@ArafatKhan2198 Thanks for working on this patch. LGTM +1
sumitagrawl
approved these changes
Jul 13, 2023
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@ArafatKhan2198 LGTM +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch aims to address a bug in Recon that triggers an error with the following message: "
org.apache.hadoop.ozone.om.helpers.RepeatedOmKeyInfo cannot be cast to org.apache.hadoop.ozone.om.helpers.OmKeyInfo".The error occurs during event processing in the Recon server, specifically within the
NSSummaryTaskWithFSOclass atline 91. It appears to be a class casting issue, where an object of typeRepeatedOmKeyInfois mistakenly cast asOmKeyInfo.To resolve this bug, we recommend modifying the
OMDBUpdatesHandlerclass responsible for creatingOmdbUpdateEvents. The approach involves ensuring that the events are not created with incorrect object types, as these are considered invalid.To implement this solution, we introduce a new utility class called
OmUpdateEventValidator. This class is designed to validateOMDBUpdateEventsand can be extended for different types of validations. Its purpose is to check the expected value type for a given table against the actual value type provided in the event. If the types do not match, the validation fails, and the even is not consumed.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8310
How was this patch tested?
The existing unit tests passed successfully, and additional unit tests were added to test the validation class.