HDDS-8011. IllegalArgumentException logged for invalid user-defined metadata#5160
Merged
Conversation
added 2 commits
August 8, 2023 15:34
Xushaohong
reviewed
Aug 8, 2023
added 2 commits
August 8, 2023 17:17
Xushaohong
reviewed
Aug 8, 2023
Tejaskriya
changed the title
Contributor
Author
|
@Xushaohong Could you please review this again, I have made all the suggested changes! |
Contributor
Looks fine to me now. Thx @Tejaskriya @adoroszlai Could you please help take a look? |
ChenSammi
reviewed
Aug 16, 2023
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
Thanks @Tejaskriya for the patch, LGTM +1.
ChenSammi
approved these changes
Aug 21, 2023
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @Tejaskriya for the contribution.
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…er-defined metadata (apache#5160) (cherry picked from commit 5cf43fc) Change-Id: Ie0fc164121a31f0d090a216791b9ca56ae34d0ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replacing the IllegalArgumentException thrown with a new OS3Exception for MetadataTooLarge.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8011
How was this patch tested?
Manually tested in Docker set-up using an API development tool to send a request to s3g.
cURL form of the request used to test: https://gist.github.com/Tejaskriya/7a8740cb2152ba7704030835ae8b85f1
Output seen:
Also tested using a test case in TestEndpointBase.java.