HDDS-9139. Can't set volume space quota on volume if volume has linked bucket#5164
Merged
sadanand48 merged 3 commits intoapache:masterfrom Aug 10, 2023
Merged
HDDS-9139. Can't set volume space quota on volume if volume has linked bucket#5164sadanand48 merged 3 commits intoapache:masterfrom
sadanand48 merged 3 commits intoapache:masterfrom
Conversation
swagle
reviewed
Aug 9, 2023
Contributor
swagle
left a comment
swagle
left a comment
There was a problem hiding this comment.
+1 LGTM. @sumitagrawl please tag if someone else should also double check. Thanks.
swagle
approved these changes
Aug 9, 2023
sadanand48
approved these changes
Aug 9, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @sumitagrawl for the patch, LGTM too.
Contributor
|
Thanks @sumitagrawl for the patch and @swagle for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
skip linked bucket for space quota check when setting volume quota
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9139
How was this patch tested?
UT cases added