HDDS-7713. listKeys with prefix path as key for FSO buckets is redundant#5170
Merged
sadanand48 merged 5 commits intoapache:masterfrom Aug 14, 2023
Merged
HDDS-7713. listKeys with prefix path as key for FSO buckets is redundant#5170sadanand48 merged 5 commits intoapache:masterfrom
sadanand48 merged 5 commits intoapache:masterfrom
Conversation
sadanand48
reviewed
Aug 10, 2023
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreWithFSO.java
Show resolved
Hide resolved
Contributor
|
LGTM Overall. Thanks ! Here's a minor suggestion from my perspective. @Test
public void testListKeysWithValidStartKey() throws Exception {
// case-10: keyPrefix corresponds an exist file
expectedKeys =
getExpectedKeyList("a1/b3/e3/e31.tx", "", legacyOzoneBucket);
checkKeyList("a1/b3/e3/e31.tx", "", expectedKeys, fsoOzoneBucket);
}Result will be |
Contributor
|
NIT: title can be specified FSO |
Contributor
Author
Thank you for the suggestion, I have added the test case you've specified in |
Contributor
|
+1, once ci passed. |
Contributor
|
Thanks @Tejaskriya for the patch, @whbing @aryangupta1998 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The redundant listing of keys was originating from the client module (it was visible from both
aws s3 lsandozone sh key listinterfaces). The change proposed is to not add the prefix to the result list if the prefix is for a key and not a directory.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7713
How was this patch tested?
Tested manually using docker.
Through S3:
Through ozone sh:
Also added a test in testListKeysAtDifferentLevels() of TestObjectStoreWithFSO.