HDDS-9157. [Snapshot] Print correct snapshot path in fs -createSnapshot#5174
Merged
smengcl merged 3 commits intoapache:masterfrom Aug 22, 2023
Merged
HDDS-9157. [Snapshot] Print correct snapshot path in fs -createSnapshot#5174smengcl merged 3 commits intoapache:masterfrom
fs -createSnapshot#5174smengcl merged 3 commits intoapache:masterfrom
Conversation
swamirishi
requested changes
Aug 11, 2023
Contributor
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @smengcl. Changes over all look good to me. Just nitpicky comments here.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsSnapshot.java
Show resolved
Hide resolved
aswinshakil
approved these changes
Aug 16, 2023
Member
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for the fix @smengcl. LGTM!
Contributor
Author
|
Thanks @aswinshakil @swamirishi for reviewing this! |
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…che#5174) Change-Id: I7d9fdd635910a1c1638a6860b926208d12986ba3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fs -createSnapshot.cc @hemantk-12
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9157
How was this patch tested?
TestOzoneFsSnapshot.