Skip to content

Comments

HDDS-9157. [Snapshot] Print correct snapshot path in fs -createSnapshot#5174

Merged
smengcl merged 3 commits intoapache:masterfrom
smengcl:HDDS-9157-cs-print
Aug 22, 2023
Merged

HDDS-9157. [Snapshot] Print correct snapshot path in fs -createSnapshot#5174
smengcl merged 3 commits intoapache:masterfrom
smengcl:HDDS-9157-cs-print

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Aug 11, 2023

What changes were proposed in this pull request?

  • Correctly print snapshot path when subdirectories are specified during snapshot creation with fs -createSnapshot.

cc @hemantk-12

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9157

How was this patch tested?

  • Added new test case in TestOzoneFsSnapshot.

@smengcl smengcl added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Aug 11, 2023
Copy link
Contributor

@swamirishi swamirishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @smengcl. Changes over all look good to me. Just nitpicky comments here.

Copy link
Member

@aswinshakil aswinshakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @smengcl. LGTM!

@smengcl smengcl merged commit ec280f4 into apache:master Aug 22, 2023
@smengcl
Copy link
Contributor Author

smengcl commented Aug 22, 2023

Thanks @aswinshakil @swamirishi for reviewing this!

swamirishi pushed a commit to swamirishi/ozone that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants