HDDS-9132. [snapshot] Add unordered snapshot deletion unit-testcase#5194
Merged
sadanand48 merged 2 commits intoapache:masterfrom Aug 21, 2023
Merged
HDDS-9132. [snapshot] Add unordered snapshot deletion unit-testcase#5194sadanand48 merged 2 commits intoapache:masterfrom
sadanand48 merged 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Please review - @nilotpalnandi @smengcl @sadanand48 |
Contributor
|
Thanks @jyotirmoy-gh for the test case. Can you address the findbugs warning: https://github.com/apache/ozone/actions/runs/5889493468/job/15992065863?pr=5194#step:6:2365 |
sadanand48
reviewed
Aug 18, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @jyotirmoy-gh , looks good overall.
...gration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneSnapshotRestore.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Made some changes for above fix. Please review - @smengcl |
sadanand48
approved these changes
Aug 21, 2023
Contributor
|
Thanks @jyotirmoy-gh for the test , @smengcl for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add unordered snapshot deletion unit-testcase -
TestOzoneSnapshotRestore#testUnorderedDeletionWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9132
How was this patch tested?
Testcase file -
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneSnapshotRestore.java