HDDS-9201. [Ozone-Streaming] Stream copy object support on gateway#5210
Merged
captainzmc merged 6 commits intoapache:masterfrom Sep 7, 2023
Merged
HDDS-9201. [Ozone-Streaming] Stream copy object support on gateway#5210captainzmc merged 6 commits intoapache:masterfrom
captainzmc merged 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
all ci passed, see: https://github.com/guohao-rosicky/ozone/actions/runs/5946593623 |
hemantk-12
reviewed
Aug 25, 2023
Contributor
There was a problem hiding this comment.
Thanks @guohao-rosicky for working on this.
- PR/Jira description is missing the motivation behind the change. It would be great if you add more details there.
- I doubt if existing tests are sufficient. We might not be reaching here: https://github.com/apache/ozone/pull/5210/files#diff-bd6abd262ed8e24eaeea5cb0e7c2a1a128411b284f9f27dae1ad47be6717a940R1011 based on current tests. Please correct me if we already have test for it.
| volume.getName(), destBucket, destKey, srcKeyLen, | ||
| replication, metadata)) { | ||
| copyLength = IOUtils.copyLarge(src, dest); | ||
| if (datastreamEnabled && !((replication != null && |
Contributor
There was a problem hiding this comment.
Suggested change
| if (datastreamEnabled && !((replication != null && | |
| if (datastreamEnabled && !(replication != null && | |
| replication.getReplicationType() == EC) && | |
| srcKeyLen > datastreamMinLength) { |
Please remove redundant parentheses.
Contributor
Author
|
Thanks @hemantk-12 for the review. |
Contributor
Author
hi, @hemantk-12, The description has been updated |
captainzmc
approved these changes
Sep 6, 2023
Member
captainzmc
left a comment
captainzmc
left a comment
There was a problem hiding this comment.
The change looks good. Wait for CI execution.
Contributor
Author
|
Thanks @captainzmc for the review, all ci passed. |
Member
|
Thanks @guohao-rosicky for the patch. And thanks @hemantk-12 for the review. Let's merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Stream copy object support on gateway.
The current gateway only supports uploading files using craft in the copy object section, this pr uses stream to support the copy object.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9201
How was this patch tested?
Existing UT