HDDS-9206. testSnapshotBackgroundServices is failing most of the time in workflow run#5219
Merged
GeorgeJahad merged 2 commits intoapache:masterfrom Aug 24, 2023
Merged
Conversation
hemantk-12
reviewed
Aug 24, 2023
| currentCompactionLog); | ||
|
|
||
| checkIfCompactionBackupFilesWerePruned(sstBackupDir, numberOfSstFiles); | ||
| // TODO: create Jira to fix and re-enable this test |
Contributor
There was a problem hiding this comment.
Can you please create a jira and attach it here? Or use HDDS-9206? What ever you feel like?
Contributor
Author
There was a problem hiding this comment.
I added to PR description. Will add in code as well.
hemantk-12
approved these changes
Aug 24, 2023
Contributor
There was a problem hiding this comment.
Thanks for the patch @mladjan-gadzic and quick fix.
Contributor
Author
|
Thank you @hemantk-12 for a quick response and review! |
GeorgeJahad
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Assertion that times out (compaction backup files pruning) during workflow run is commented out. This is only a temporary solution, because compaction backup files pruning is just a part of larger set of snapshot background services tests which are important. Jira HDDS-9209 is created to fix this.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9206
How was this patch tested?