HDDS-7553. Ozone OM stopped with iIllegalStateException.#5222
Merged
szetszwo merged 6 commits intoapache:masterfrom Aug 29, 2023
Merged
HDDS-7553. Ozone OM stopped with iIllegalStateException.#5222szetszwo merged 6 commits intoapache:masterfrom
szetszwo merged 6 commits intoapache:masterfrom
Conversation
sadanand48
reviewed
Aug 25, 2023
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
szetszwo
previously approved these changes
Aug 25, 2023
Contributor
There was a problem hiding this comment.
@aryangupta1998 , thanks for working on this! The idea looks good. However, there are many test failures. When the storage directory is not set in both SCM and OM, they will use the same directory. Then OM will fail when it restarts after this change.
sumitagrawl
approved these changes
Aug 28, 2023
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@aryangupta1998 LGTM +1
sadanand48
approved these changes
Aug 29, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @aryangupta1998 for addressing the comments, LGTM
szetszwo
approved these changes
Aug 29, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
|
@sadanand48 , @sumitagrawl thanks a lot for reviewing this! |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…pache#5222) (cherry picked from commit 827ee4e) Change-Id: I62c3d3de6f2ba528dd9a0283f53662a66e3a6e3c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, we don't support om service id change but if someone changes om service id then we throw a warning message which results in the creation of a new raft group directory with respect to the new om service id and finally leads to iIllegalStateException. This PR aims to prevent the om service id change by throwing an exception, with this PR we also prevent the existence of SCM and OM ratis storage directory at the same path.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7553
How was this patch tested?
Tested Manually.