Skip to content

HDDS-9266. Acceptance test for snapshot data validation after OM bootstrapping#5350

Merged
hemantk-12 merged 3 commits intoapache:masterfrom
xBis7:HDDS-9266
Nov 28, 2023
Merged

HDDS-9266. Acceptance test for snapshot data validation after OM bootstrapping#5350
hemantk-12 merged 3 commits intoapache:masterfrom
xBis7:HDDS-9266

Conversation

@xBis7
Copy link
Contributor

@xBis7 xBis7 commented Sep 22, 2023

What changes were proposed in this pull request?

This PR, is adding a new test setup to run under ozonesecure-ha docker env for validating snapshot data installed with a Ratis snapshot under a bootstrapped OM.

The test follows the below steps

  • Starts with om3 inactive and uninitialized
  • Calls a robot test for creating data, the test:
    • Creates 100 metadata keys
    • Creates snapshot 1
    • Creates 2 actual keys and set the key contents the same as the key name
    • Creates snapshot 2
  • Checks that om3 isn't running
  • Checks that om3 has no data
  • Bootstraps om3
  • Checks that om3 is now running
  • Checks that om3 has data
  • Calls a robot test for validating the data, the test:
    • Waits until checkpoints have been created on om3
    • Checks that om3 isn't the leader
    • Transfer leadership to om3, to perform regular leader reads
    • Checks that the snapshots exist on om3
    • Runs a snapshot diff and validates results
    • Checks key contents

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9266

How was this patch tested?

This patch is adding new acceptance tests. Two green CI workflows on my fork.

https://github.com/xBis7/ozone/actions/runs/6264845503

https://github.com/xBis7/ozone/actions/runs/6264807295

@GeorgeJahad GeorgeJahad added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Sep 22, 2023
Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @xBis7

I took a high level view and good addition to CD/CI. Left some minor comments.

@xBis7 xBis7 requested a review from hemantk-12 November 16, 2023 18:35
@xBis7 xBis7 added the test label Nov 22, 2023
@xBis7 xBis7 requested a review from adoroszlai November 22, 2023 11:50
Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hemantk-12 hemantk-12 merged commit 289739f into apache:master Nov 28, 2023
@hemantk-12
Copy link
Contributor

Thanks for working on this @xBis7

@xBis7
Copy link
Contributor Author

xBis7 commented Nov 28, 2023

Thanks @hemantk-12 for the review and merge.

swamirishi pushed a commit to swamirishi/ozone that referenced this pull request Dec 3, 2025
…fter OM bootstrapping (apache#5350)

Change-Id: I4c496c2d17537ca4c9ff142e10f6be382f183153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517 test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants