HDDS-9356. Ozone debug chunkinfo shows incorrect block path for some nodes#5402
Merged
sadanand48 merged 3 commits intoapache:masterfrom Oct 10, 2023
Merged
HDDS-9356. Ozone debug chunkinfo shows incorrect block path for some nodes#5402sadanand48 merged 3 commits intoapache:masterfrom
sadanand48 merged 3 commits intoapache:masterfrom
Conversation
sadanand48
approved these changes
Oct 10, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @aryangupta1998 for the patch, LGTM.
vtutrinov
pushed a commit
to vtutrinov/ozone
that referenced
this pull request
Oct 11, 2023
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The block file path is incorrect for some nodes sometimes. All paths are the same (in the same data disks) in all the nodes, but in actuality, some of the nodes have the block path in different data disks. The problem is due to readContainer reading from the first node of the pipeline. If paths(storage dir) are different for different DN, then the tool needs to query every DN instead of just the first node similar to getBlockFromAllNodes.
So, we are querying every data node present in the pipeline to get the block information to display correct block paths.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9356
How was this patch tested?
Tested Manually.