HDDS-9434. Intermittent failure in TestSnapshotDiffManager#testLoadJobsOnStartUp.#5424
Merged
adoroszlai merged 2 commits intoapache:masterfrom Oct 21, 2023
Merged
HDDS-9434. Intermittent failure in TestSnapshotDiffManager#testLoadJobsOnStartUp.#5424adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@swamirishi can you please take a look |
hemantk-12
reviewed
Oct 20, 2023
Contributor
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks for the patch @sadanand48. Overall looks good to me.
Can you please run all the tests in TestSnapshotDiffManager 10x10 times instead of just testLoadJobsOnStartUp?
Contributor
Author
|
Thanks @hemantk-12 I ran all tests here : https://github.com/sadanand48/hadoop-ozone/actions/runs/6585565236/job/17892237098 . |
hemantk-12
approved these changes
Oct 20, 2023
Contributor
|
Thanks @sadanand48 for the patch, @hemantk-12 for the review. |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix intermittent failure in the test by waiting till the method is invoked.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9434
How was this patch tested?
Test successfully ran for 20 x 15 times : https://github.com/sadanand48/hadoop-ozone/actions/runs/6482699582