Skip to content

Comments

HDDS-9449. Create pipeline consider datanode storage.#5434

Closed
z-bb wants to merge 1 commit intoapache:masterfrom
z-bb:HDDS-9449
Closed

HDDS-9449. Create pipeline consider datanode storage.#5434
z-bb wants to merge 1 commit intoapache:masterfrom
z-bb:HDDS-9449

Conversation

@z-bb
Copy link
Contributor

@z-bb z-bb commented Oct 13, 2023

What changes were proposed in this pull request?

Currently, for clusters with unbalanced, the storage of the dn machine needs to be considered when creating a new pipeline. should not select a dn with full storage, because exceptions such as the machine being filled up or writing failure may occur.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9449

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @z-bb for working on this.

I'm not sure this change is necessary. There is already a setting to reserve some disk space on Datanode for other usage. It can be configured as absolute space or percentage. I think setting reserved to 10% has the same effect as setting this new datanode storage rate limit to 90%.

<property>
<name>hdds.datanode.dir.du.reserved.percent</name>
<value/>
<tag>OZONE, CONTAINER, STORAGE, MANAGEMENT</tag>
<description>Percentage of volume that should be reserved. This space is left free for other usage.
The value should be between 0-1. Such as 0.1 which means 10% of volume space will be reserved.
</description>
</property>

@kerneltime kerneltime requested a review from ChenSammi October 16, 2023 16:31
@errose28
Copy link
Contributor

I agree with @adoroszlai. I think between reserving space on datanodes and using SCMContainerPlacementCapacity for the container placement algorithm we can get the desired result.

@z-bb
Copy link
Contributor Author

z-bb commented Oct 18, 2023

I agree with @adoroszlai. I think between reserving space on datanodes and using SCMContainerPlacementCapacity for the container placement algorithm we can get the desired result.

okey, i will close this mr. thanks review

@z-bb z-bb closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants