HDDS-9450. Enhance om-leader-transfer.robot#5439
Merged
adoroszlai merged 5 commits intoapache:masterfrom Oct 17, 2023
Merged
Conversation
Contributor
Author
|
Passing in local. |
Contributor
Author
|
Hi @adoroszlai can you please review this? |
adoroszlai
reviewed
Oct 15, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @LZD-PratyushBhatt for working on this. Mostly looks good, some code improvements suggested.
hadoop-ozone/dist/src/main/smoketest/omha/om-leader-transfer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/omha/om-leader-transfer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/omha/om-leader-transfer.robot
Outdated
Show resolved
Hide resolved
Contributor
Contributor
|
cc @swamirishi |
Contributor
Author
|
Pass results after the change: |
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @LZD-PratyushBhatt for the patch, the changes look good to me.
Previously, we encountered failures in the om-leader-transfer tests when writes preceded them, as discussed in PR #4844 comment.
NIT: Testing leader transfer commands with writes executed prior might be worthwhile (if possible).
adoroszlai
approved these changes
Oct 17, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @LZD-PratyushBhatt for updating the patch. I have some ideas for future improvement ;), but we can merge this as is.
Contributor
|
Thanks @LZD-PratyushBhatt for the patch, @tanvipenumudy for the review. |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhancing om-leader-transfer.robot by testing more cli options
What is the link to the Apache JIRA
HDDS-9450
How was this patch tested?
Modified the robot tests.
Passed CI: https://github.com/LZD-PratyushBhatt/ozone/actions/runs/6506536393/job/17673227311?pr=9