HDDS-9447. Redundant ACL checks in getKeyInfo for S3 use case#5440
Merged
adoroszlai merged 3 commits intoapache:masterfrom Oct 19, 2023
Merged
HDDS-9447. Redundant ACL checks in getKeyInfo for S3 use case#5440adoroszlai merged 3 commits intoapache:masterfrom
adoroszlai merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
cc @SaketaChalamchala @tanvipenumudy @swamirishi @xBis7 can you please take a look. |
xBis7
approved these changes
Oct 17, 2023
Contributor
xBis7
left a comment
xBis7
left a comment
There was a problem hiding this comment.
@duongkame Thanks for the patch. Since, we are checking the S3 volume ACLs for all bucket layouts here, on the OmMetadataReader, it's redundant to check the volume ACLs again, when validating for a key.
Changes LGTM!
tanvipenumudy
approved these changes
Oct 17, 2023
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @duongkame for the patch, the changes LGTM! Added a minor nit.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Oct 19, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @duongkame for the patch. One minor comment nit inline.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
…ne/om/OzoneManager.java Co-authored-by: Siyao Meng <50227127+smengcl@users.noreply.github.com>
Contributor
|
Thanks @duongkame for the patch, @smengcl, @tanvipenumudy, @xBis7 for the review. |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Redundant ACL checks in getKeyInfo for S3 use case. See details in the JIRA.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9447
How was this patch tested?
Should be covered by the existing tests in CI.