HDDS-9466. Introduce FlakyTest category for flaky JUnit4 tests#5457
Merged
adoroszlai merged 2 commits intoapache:masterfrom Oct 19, 2023
Merged
HDDS-9466. Introduce FlakyTest category for flaky JUnit4 tests#5457adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
sadanand48
reviewed
Oct 19, 2023
.../integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java
Show resolved
Hide resolved
sadanand48
approved these changes
Oct 19, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the patch, LGTM.
Contributor
Author
|
Thanks @sadanand48 for the review. |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
@Flakytag only applies to JUnit5 tests. This change implements a similar feature for JUnit4 tests. Now JUnit4 tests can be annotated with@Category(FlakyTest.class)to execute them in integration (flaky) (with few repetitions if necessary) instead of their regular integration split.Also mark
TestStorageContainerManager#testContainerReportQueueTakingMoreTimeas flaky (see HDDS-8470).https://issues.apache.org/jira/browse/HDDS-9466
How was this patch tested?
Test marked as
@Category(FlakyTest.class)was executed in integration (flaky):https://github.com/adoroszlai/hadoop-ozone/actions/runs/6544313982/job/17771626430#step:6:3824
Other tests in same class were executed in integration (scm):
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6544313982/job/17771625577#step:5:3848