HDDS-9511. Handle DataNode decommissioning error for hoststring and port.#5469
Merged
adoroszlai merged 2 commits intoapache:masterfrom Oct 23, 2023
Merged
HDDS-9511. Handle DataNode decommissioning error for hoststring and port.#5469adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
sodonnel
approved these changes
Oct 23, 2023
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM. I don't recall why I made other errors be returned in the DatanodeAdminErrors, but the initial host parsing not. However I believe it makes sense to make this change.
+1 pending green CI.
Contributor
|
Thanks @ashishkumar50 for the patch, @sodonnel for the review. |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…string and port. (apache#5469) (cherry picked from commit 2f9f771) Change-Id: I114616fdf2554bf50da59d3cc97270d4db246738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When decommission command is executed and if port or hostname is wrong and doesn't present in SCM, in that case command retries for 300 times which is unnecessary.
In this PR we are fixing below:
If hoststring or port is wrong, instead of throwing exception we are returning DataNodeAdmin error which will avoid retry and will be normal exit.
If there are multiple hosts passed in the command, hosts which are invalid we add into error list and continue decommissioning for the proper host.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9511
How was this patch tested?
Update existing tests and verify