HDDS-9363. Updated pull request template to remove PR title confusion#5483
Merged
hemantk-12 merged 2 commits intoapache:masterfrom Oct 25, 2023
Merged
HDDS-9363. Updated pull request template to remove PR title confusion#5483hemantk-12 merged 2 commits intoapache:masterfrom
hemantk-12 merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Oct 24, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 for the patch.
I suggest dropping the numbered list completely.
Contributor
|
Thanks @hemantk-12 for updating PR, LGTM. Would you like to ask others for review? |
Contributor
Author
I asked in Ozone slack channel if anyone is interested in review or have more suggestions to make it intuitive. |
errose28
approved these changes
Oct 24, 2023
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for the updates @hemantk-12 this looks more intuitive to me as well.
dombizita
approved these changes
Oct 25, 2023
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for updating the PR template @hemantk-12, it makes sense to me!
Contributor
Author
|
Thanks for the review and suggestions @adoroszlai, @errose28 , @dombizita |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In PR #5372, pull request template was updated to provide more context in PRs description. But it created confusion and title is duplicated in PR description as well.
This change is to update the template so that title is not duplicated in description and only added to the PR title field.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9363
How was this patch tested?
No testing. Just documentation change.